Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.0.2 #25

Merged
merged 17 commits into from
Nov 6, 2023
Merged

v0.0.2 #25

merged 17 commits into from
Nov 6, 2023

Conversation

Sabnock01
Copy link
Member

@Sabnock01 Sabnock01 commented Nov 3, 2023

Various updates and bug fixes to the Curta contracts:

  • Add script for previewing Flag SVG's.
  • Update FlagRenderer.sol to use v0.0.2 of the ColormapRegistry.
  • Add address check on addPuzzle for checking against the zero address and the Curta address.
  • Add check in addPuzzle for puzzle.name() being zero length. This is to avoid broken tokenURI's.
  • Fix bug that shows the Solver trait as the last 28 bits of the solver's solution instead of the solver's address.
  • Fix stars rendering so that they are correctly shown as the NFT's card color instead of colorless.

@Sabnock01 Sabnock01 marked this pull request as ready for review November 4, 2023 14:04
bytes32(0x87970b686eb726750ec792d49da173387a567764d691294d764e53439359c436),
bytes32(0xaa6277ab923279cf59d78b9b5b7fb5089c90802c353489571fca3c138056fb1b),
bytes32(0xdc1cecffc00e2f3196daaf53c27e53e6052a86dc875adb91607824d62469b2bf)
bytes8 colormapHash = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it better if we packed 4 of these per bytes32? I guess it's unnecessary lmao

Copy link
Member

@fiveoutofnine fiveoutofnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sabnock01 Sabnock01 merged commit 2262455 into main Nov 6, 2023
2 checks passed
@fiveoutofnine fiveoutofnine deleted the sabnock/flag-renderer-updates branch November 14, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants